feat(ProgressiveBilling): Bill current usage #2461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
force-pushed
the
feat-progressive-billing-fixes
branch
from
3b91911
to
ae60257
Compare
nudded
reviewed
Aug 22, 2024
nudded
approved these changes
Aug 22, 2024
vincent-pochet
force-pushed
the
feat-progressive-billing-fixes
branch
from
ae60257
to
8dfd783
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI companies want their users to pay before the end of a period if usage skyrockets. The problem being that self-serve companies can overuse their API without paying, triggering lots of costs on their side.
Description
This PR refactors the
Invoices::ProgressiveBillingServiceto create current usage fees, instead of a single progressive billings one per threshold.Note: The logic to apply progressive billing credits to the invoice in order to avoid double billing will be handled in a separate pull request as the current one is already complex. The PDF template will also be adapted separatly